Skip to content

feat(experiment): add apps.icon.set support for non-hosted app icons#469

Open
srtaalej wants to merge 4 commits intomainfrom
ale-set-icon
Open

feat(experiment): add apps.icon.set support for non-hosted app icons#469
srtaalej wants to merge 4 commits intomainfrom
ale-set-icon

Conversation

@srtaalej
Copy link
Copy Markdown
Contributor

@srtaalej srtaalej commented Apr 3, 2026 •
edited
Loading

Changelog

No user-facing changes until apps.icon.set endpoint is live

Summary

This PR adds IconSet() API method targeting the apps.icon.set endpoint for non-hosted (Bolt) app icons. Gated behind the set-icon experiment flag (--experiment=set-icon) (see Note)

Note

🔴 The apps.icon.set endpoint is not yet publicly available. This PR is ready to ship once the endpoint is live. No changes were made to the existing apps.hosted.icon flow.

Required scope (app_configurations:write) may be subject to change before the endpoint goes public

Test plan

slack run --experiment=set-icon with an icon.png uploads icon once endpoint is available
slack run without the experiment flag does not attempt icon upload for non-hosted apps
slack deploy for hosted apps continues to work as before

Requirements

@srtaalej srtaalej self-assigned this Apr 3, 2026
@srtaalej srtaalej added enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.02%. Comparing base (a6658e3) to head (27ba074).

Files with missing lines Patch % Lines
internal/pkg/apps/install.go 0.00% 12 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   71.08%   71.02%   -0.06%     
==========================================
  Files         220      220              
  Lines       18512    18529      +17     
==========================================
+ Hits        13160    13161       +1     
- Misses       4177     4189      +12     
- Partials     1175     1179       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej marked this pull request as ready for review April 6, 2026 22:56
@srtaalej srtaalej requested a review from a team as a code owner April 6, 2026 22:56
@srtaalej srtaalej requested review from mwbrooks and zimeg April 7, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

@zimeg zimeg Awaiting requested review from zimeg

At least 1 approving review is required to merge this pull request.

Assignees

@srtaalej srtaalej

Labels

enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@srtaalej